Change in ...osmo-iuh[master]: iu_client: sccp_sap_up: don't decode empty disconnect indications

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Tue Sep 3 17:43:47 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15180 )

Change subject: iu_client: sccp_sap_up: don't decode empty disconnect indications
......................................................................


Patch Set 5: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/15180/5/src/iu_client.c 
File src/iu_client.c:

https://gerrit.osmocom.org/#/c/15180/5/src/iu_client.c@802 
PS5, Line 802: 		rc = 0;
I hope at some point this "rc = 0" is moved up in order to set rc if !ue condition is hit, otherwise it looks like rc will be returned uninitialized.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15180
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: I1fea8f19433d908583de71d8d2401bbb8c0c7900
Gerrit-Change-Number: 15180
Gerrit-PatchSet: 5
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 03 Sep 2019 17:43:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190903/0ef3d8d2/attachment.htm>


More information about the gerrit-log mailing list