Change in ...osmo-msc[master]: ran_dec logging: log message sizes on errors

[neels]

neels has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-msc/+/15342 )

Change subject: ran_dec logging: log message sizes on errors
......................................................................

ran_dec logging: log message sizes on errors

Change-Id: Id08e4ee5a4dbf552dbb107d8f0519110664f6acb
---
M src/libmsc/ran_msg_a.c
1 file changed, 7 insertions(+), 3 deletions(-)

Approvals:
  fixeria: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/libmsc/ran_msg_a.c b/src/libmsc/ran_msg_a.c
index fd8afdc..43e27f6 100644
--- a/src/libmsc/ran_msg_a.c
+++ b/src/libmsc/ran_msg_a.c
@@ -761,13 +761,17 @@
 	}
 
 	if (msgb_l3len(bssmap) < h->length) {
-		LOG_RAN_A_DEC(ran_dec, LOGL_ERROR, "BSSMAP data truncated, discarding message\n");
+		LOG_RAN_A_DEC(ran_dec, LOGL_ERROR, "BSSMAP data truncated, discarding message:"
+			      " msgb_l3len(bssmap) == %u < bssmap_header->length == %u\n",
+			      msgb_l3len(bssmap), h->length);
 		return -1;
 	}
 
 	if (msgb_l3len(bssmap) > h->length) {
-		LOG_RAN_A_DEC(ran_dec, LOGL_NOTICE, "There are %u extra bytes after the BSSMAP data, truncating\n",
-			     msgb_l3len(bssmap) - h->length);
+		LOG_RAN_A_DEC(ran_dec, LOGL_NOTICE, "There are %u extra bytes after the BSSMAP data, truncating:"
+			      " msgb_l3len(bssmap) == %u > bssmap_header->length == %u\n",
+			      msgb_l3len(bssmap) - h->length,
+			      msgb_l3len(bssmap), h->length);
 		msgb_l3trim(bssmap, h->length);
 	}
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15342
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Id08e4ee5a4dbf552dbb107d8f0519110664f6acb
Gerrit-Change-Number: 15342
Gerrit-PatchSet: 6
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190903/b8382d74/attachment.htm>