Change in ...osmo-ttcn3-hacks[master]: pcu/GPRS_TBF.ttcn: less verbose logging

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Mon Sep 2 09:01:45 UTC 2019


laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15349 )

Change subject: pcu/GPRS_TBF.ttcn: less verbose logging
......................................................................

pcu/GPRS_TBF.ttcn: less verbose logging

Reduce the formatted log size of TC_ul_tbf from ~140 MB to ~8 MB.

Related: OS#3925
Change-Id: Ibccfc399a6e8b50e4f01b5f167c47fbbde4533ed
---
M pcu/GPRS_TBF.ttcn
1 file changed, 0 insertions(+), 3 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/pcu/GPRS_TBF.ttcn b/pcu/GPRS_TBF.ttcn
index 9fbe191..1c9a75b 100644
--- a/pcu/GPRS_TBF.ttcn
+++ b/pcu/GPRS_TBF.ttcn
@@ -144,8 +144,6 @@
 	us.cur_index := us.cur_index + len;
 	us.total_bytes_remain := us.total_bytes_remain - len;
 
-	log("copy_from_llc: ", ret, " us: ", us);
-
 	/* if we completed this PDU, move on to the next, resetting the index */
 	if (us.cur_index >= pdu_len) {
 		us.cur_pdu := us.cur_pdu +1;
@@ -307,7 +305,6 @@
 	var integer blk_len_net := f_gprs_blocksize(cs) - hdr_size;
 	var integer num_remain := f_div_round_up(us.total_bytes_remain, blk_len_net);
 	var integer cv := f_calc_cv(num_remain + sizeof(us.rlc_sent), us.bsn_p, us.num_ts, us.tbf.initial_cs, 14 /* FIXME */);
-	log("CV=", cv, ", num_rmain=", num_remain, " from ", us);
 	return cv;
 }
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15349
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ibccfc399a6e8b50e4f01b5f167c47fbbde4533ed
Gerrit-Change-Number: 15349
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190902/ecb55b4f/attachment.htm>


More information about the gerrit-log mailing list