This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15918 ) Change subject: l1sap: merge MEAS IND into PRIM PH DATA / PRIM TCH ...................................................................... Patch Set 1: (5 comments) https://gerrit.osmocom.org/c/osmo-bts/+/15918/1/src/common/l1sap.c File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/15918/1/src/common/l1sap.c@67 PS1, Line 67: * indication for itsself that is passed up in parallel to the payload data itself https://gerrit.osmocom.org/c/osmo-bts/+/15918/1/src/common/l1sap.c@74 PS1, Line 74: static bool tch_data_meas_present = true; I'm not liking that much the idea behind this variable. IIUC, some BTS models send this while some other don't. Let's then better please add a per-bts-model API which tells us whether the BTS being used is expected to receive it or not instead of detecting it at runtime. https://gerrit.osmocom.org/c/osmo-bts/+/15918/1/src/common/l1sap.c@646 PS1, Line 646: struct info_meas_ind_param *info_meas_ind = &l1sap->u.info.u.meas_ind; Let's rather move these assignments under each switch case. https://gerrit.osmocom.org/c/osmo-bts/+/15918/1/src/common/l1sap.c@695 PS1, Line 695: "%s MPH_INFO meas ind, ta_offs_256bits=%d, ber10k=%d, inv_rssi=%u\n", MPH_INFO only on some case right? maybe add a string pointing to the name in the switch case. https://gerrit.osmocom.org/c/osmo-bts/+/15918/1/src/common/l1sap.c@740 PS1, Line 740: rc = 0; rc is already zero here, it can be dropped. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15918 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I710d0b7cf193afa8515807836ee69b8b7db84a84 Gerrit-Change-Number: 15918 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Thu, 31 Oct 2019 11:47:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191031/2f1e61df/attachment.htm>