Change in libosmocore[master]: add osmo_fsm_set_dealloc_ctx(), to help with use-after-free

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Wed Oct 30 11:42:49 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15677 )

Change subject: add osmo_fsm_set_dealloc_ctx(), to help with use-after-free
......................................................................


Patch Set 3:

> (If I could go back, I would actually undo osmo_fsm_term_safely() and rather use this more elegant solution instead.)

You can still go back if you think it's needed, it was not yet released as far as I know.

> If you doubt the necessity of solving these problems

I'm not saying these problems don't exist or don't need to be solved, I'm just saying I'm not liking the approaches I see are being taken here. I still have the feeling it be better fixing it by adding delete_cb or passing some specific return codes somewhere like we do with -EBADF during read_cb() in other libosmocore APIs. But since I cannot spend time on this, go ahead with merging this if you think it's really the best or only way.


-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15677
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ief4dba9ea587c9b4aea69993e965fbb20fb80e78
Gerrit-Change-Number: 15677
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 30 Oct 2019 11:42:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191030/bae0d095/attachment.htm>


More information about the gerrit-log mailing list