Change in osmo-hlr[master]: fix double free in osmo_gsup_client_enc_send()

[neels]

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/15900 )


Change subject: fix double free in osmo_gsup_client_enc_send()
......................................................................

fix double free in osmo_gsup_client_enc_send()

Change-Id: Iee675fd498ab0867ac2411d9142358f513276182
---
M src/gsupclient/gsup_client.c
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/00/15900/1

diff --git a/src/gsupclient/gsup_client.c b/src/gsupclient/gsup_client.c
index c8408fd..814d5a2 100644
--- a/src/gsupclient/gsup_client.c
+++ b/src/gsupclient/gsup_client.c
@@ -386,7 +386,8 @@
 	rc = osmo_gsup_client_send(gsupc, gsup_msgb);
 	if (rc) {
 		LOGP(DLGSUP, LOGL_ERROR, "Couldn't send GSUP message\n");
-		goto error;
+		/* Do not free, osmo_gsup_client_send() already has. */
+		return rc;
 	}
 
 	return 0;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/15900
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Iee675fd498ab0867ac2411d9142358f513276182
Gerrit-Change-Number: 15900
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191030/bd8c92c7/attachment.htm>