Change in libosmo-sccp[master]: M3UA: Reject ASP activation + RKM registration for incompatible traff...

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/15885 )

Change subject: M3UA: Reject ASP activation + RKM registration for incompatible traffic-mode
......................................................................


Patch Set 2:

(3 comments)

https://gerrit.osmocom.org/c/libosmo-sccp/+/15885/2/src/xua_asp_fsm.c 
File src/xua_asp_fsm.c:

https://gerrit.osmocom.org/c/libosmo-sccp/+/15885/2/src/xua_asp_fsm.c@459 
PS2, Line 459: 				break;
> This one should also be a return?
ACK


https://gerrit.osmocom.org/c/libosmo-sccp/+/15885/2/src/xua_asp_fsm.c@468 
PS2, Line 468: 					break;
> This one should be a return, otherwise you send an error and later you send an ACK. […]
yes, I'll submit a separate fix.


https://gerrit.osmocom.org/c/libosmo-sccp/+/15885/2/src/xua_asp_fsm.c@473 
PS2, Line 473: 					if (!osmo_ss7_tmode_compatible_xua(as->cfg.mode, traf_mode)) {
> I'd rather have an API passing AS as the first parameter. […]
ACK



-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/15885
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Ic73410fbc88d50710202453f759fa132ce14db4c
Gerrit-Change-Number: 15885
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 29 Oct 2019 13:26:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191029/c8d8a60e/attachment.htm>