Change in libosmo-sccp[master]: xua_asp_fsm: Don't send M3UA ERR and then send ASPAC_ACK

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Tue Oct 29 13:18:21 UTC 2019


laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/15892 )


Change subject: xua_asp_fsm: Don't send M3UA ERR and then send ASPAC_ACK
......................................................................

xua_asp_fsm: Don't send M3UA ERR and then send ASPAC_ACK

IF we cannot activate the ASP in response to an ASPAC, we should
return just the error and not an error + ASPACK_ACK.

Change-Id: I681021a13af9b91d8b2b849bd7149d6b1f783865
---
M src/xua_asp_fsm.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/92/15892/1

diff --git a/src/xua_asp_fsm.c b/src/xua_asp_fsm.c
index 890a6b5..9880d55 100644
--- a/src/xua_asp_fsm.c
+++ b/src/xua_asp_fsm.c
@@ -465,7 +465,7 @@
 				rctx = osmo_load32be(&part->dat[i * sizeof(uint32_t)]);
 				if (!osmo_ss7_as_find_by_rctx(asp->inst, rctx)) {
 					peer_send_error(fi, M3UA_ERR_INVAL_ROUT_CTX);
-					break;
+					return;
 				}
 			}
 		}

-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/15892
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I681021a13af9b91d8b2b849bd7149d6b1f783865
Gerrit-Change-Number: 15892
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191029/d45389c3/attachment.htm>


More information about the gerrit-log mailing list