Change in libosmocore[master]: fsm: add osmo_fsm_set_term_stops_actions()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Thu Oct 24 22:58:30 UTC 2019


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15833 )

Change subject: fsm: add osmo_fsm_set_term_stops_actions()
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/15833/1/src/fsm.c 
File src/fsm.c:

https://gerrit.osmocom.org/c/libosmocore/+/15833/1/src/fsm.c@221 
PS1, Line 221: void osmo_fsm_set_term_stops_actions(bool term_stops_actions)
> Again, why not per FSM instance? What if I want different instances to behave differently?
Why would you want to dispatch events or allow state changes on FSM instances after osmo_fsm_inst_term()?
If you can describe such a use case then let's add a flag per-instance.
I don't see any at the moment, I think it should have been globally disabled from the start of osmo_fsm.

The only reason why I am making this optional is to allow programs remain in legacy behavior,
to avoid differences in logging and break C tests that verify log output.
I recommend each main() to enable this feature globally as soon as possible.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15833
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I0adc13a1a998e953b6c850efa2761350dd07e03a
Gerrit-Change-Number: 15833
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 24 Oct 2019 22:58:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191024/36591b5f/attachment.htm>


More information about the gerrit-log mailing list