Change in libosmocore[master]: gsm0508: add functions to calculate beginning of a block

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Thu Oct 24 12:20:01 UTC 2019


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15719 )

Change subject: gsm0508: add functions to calculate beginning of a block
......................................................................


Patch Set 6: Code-Review+1

(2 comments)

Looks good to me in general.

https://gerrit.osmocom.org/c/libosmocore/+/15719/6/src/gsm/gsm0502.c 
File src/gsm/gsm0502.c:

https://gerrit.osmocom.org/c/libosmocore/+/15719/6/src/gsm/gsm0502.c@175 
PS6, Line 175: unsigned int
We mostly use uint32_t for TDMA frame numbers, but that's not critical.


https://gerrit.osmocom.org/c/libosmocore/+/15719/6/src/gsm/gsm0502.c@183 
PS6, Line 183: ARRAY_SIZE(fn_remap_table_ptr)
Feel free to use FN_REMAP_MAX here.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15719
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I3d71c66f8c401f5afbad9b1c86c24580dab9e0ce
Gerrit-Change-Number: 15719
Gerrit-PatchSet: 6
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Thu, 24 Oct 2019 12:20:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191024/a12b9be0/attachment.htm>


More information about the gerrit-log mailing list