Change in libosmo-sccp[master]: ss7: Set Traffic Mode and Route Ctx in ASPAC msg if set in VTY

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/15817 )

Change subject: ss7: Set Traffic Mode and Route Ctx in ASPAC msg if set in VTY
......................................................................


Patch Set 4:

(2 comments)

https://gerrit.osmocom.org/c/libosmo-sccp/+/15817/4/src/xua_asp_fsm.c 
File src/xua_asp_fsm.c:

https://gerrit.osmocom.org/c/libosmo-sccp/+/15817/4/src/xua_asp_fsm.c@220 
PS4, Line 220: as = osmo_ss7_as_find_by_rctx(asp->inst, rctxs[0]);
I guess the proper thing to do here is to check if all of them have the same traffic mode, not just blindly use the traffic mode set by the first routing context/AS and assume all other contexts/AS have the same.

The full-blown spec-complete implementation would actually perform different ASP-ACTIVATE procedures for different (groups of) routing contexts, where all contexts within one group have the same traffic mode.  But this is highly theoretical and nothing we want to do here.

So either only support one routing context at all (and use that trfafic mode), or if you want to do multiple routing contexts in the ROUTE_CTX IE, then please check that they all agree in terms of the traffic mode.  This way we don't support all features, but at least behave only correctly.


https://gerrit.osmocom.org/c/libosmo-sccp/+/15817/4/src/xua_asp_fsm.c@226 
PS4, Line 226: 		if (rctx_cnt) {
             : 			for (i = 0; i < rctx_cnt; i++)
             : 				rctxs[i] = htonl(rctxs[i]);
             : 			xua_msg_add_data(xua, SUA_IEI_ROUTE_CTX, rctx_cnt * sizeof(uint32_t), (uint8_t *) &rctxs[0]);
             : 		}
AFAIR I intentionally didn't add the routing contexts IE, as the ASP-ACTIVATE is automatically for all routing contexts if the optional IE is missing.  Yes, we might add all of them, but I'm not sure what we gain by it - or whether we should mix it with the traffic-mode in one patch.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/15817
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Icce0e672f6180ebc92ca34f538d41161d02fecb9
Gerrit-Change-Number: 15817
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Wed, 23 Oct 2019 21:33:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191023/ccee5450/attachment.htm>