Change in libosmocore[master]: add osmo_fsm_set_dealloc_ctx(), to help with use-after-free

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Wed Oct 23 13:11:54 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15677 )

Change subject: add osmo_fsm_set_dealloc_ctx(), to help with use-after-free
......................................................................


Patch Set 2:

(1 comment)

As I already pointed out, I'm not liking very much all these new APIs making common FSMs more complex which could probably be fixed ad-hoc pro specific FSM users by having a delete_cb being triggered when the fsm is going to be deleted.

https://gerrit.osmocom.org/c/libosmocore/+/15677/2/src/fsm.c 
File src/fsm.c:

https://gerrit.osmocom.org/c/libosmocore/+/15677/2/src/fsm.c@198 
PS2, Line 198: void osmo_fsm_set_dealloc_ctx(void *ctx)
Should this be per fsm_instance? why limiting it to one given context for all instances?



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15677
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ief4dba9ea587c9b4aea69993e965fbb20fb80e78
Gerrit-Change-Number: 15677
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 23 Oct 2019 13:11:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191023/e4b1f802/attachment.htm>


More information about the gerrit-log mailing list