Change in libosmocore[master]: vty: Return error if cmd returns CMD_WARNING while reading cfg file

[pespin]

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/15827 )


Change subject: vty: Return error if cmd returns CMD_WARNING while reading cfg file
......................................................................

vty: Return error if cmd returns CMD_WARNING while reading cfg file

Otherwise bad configurations can easily sneak in and produce unexpected
behavior.

Change-Id: Ic9c1b566ec4a459f03e6319cf369691903cf9d00
---
M src/vty/command.c
1 file changed, 1 insertion(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/27/15827/1

diff --git a/src/vty/command.c b/src/vty/command.c
index a36f30a..6a9d18a 100644
--- a/src/vty/command.c
+++ b/src/vty/command.c
@@ -2631,8 +2631,7 @@
 		ret = cmd_execute_command_strict(vline, vty, NULL);
 		cmd_free_strvec(vline);
 
-		if (ret != CMD_SUCCESS && ret != CMD_WARNING
-		    && ret != CMD_ERR_NOTHING_TODO) {
+		if (ret != CMD_SUCCESS && ret != CMD_ERR_NOTHING_TODO) {
 			if (indent) {
 				talloc_free(indent);
 				indent = NULL;

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15827
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ic9c1b566ec4a459f03e6319cf369691903cf9d00
Gerrit-Change-Number: 15827
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191022/94054675/attachment.htm>