Change in libosmo-sccp[master]: Don't permit routing-context != 0 for IPA peers

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Mon Oct 21 11:21:28 UTC 2019


laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/15815 )

Change subject: Don't permit routing-context != 0 for IPA peers
......................................................................

Don't permit routing-context != 0 for IPA peers

The IPA protocol doesn't have the context of routing-keys. We are only
permitting routing key '0' (as the default routing key) when configuring
via VTY.

Change-Id: I3f166f44903d0b93963cc5d0cca73d277d2b7215
Fixes: OS#4234, OS#4233
---
M src/osmo_ss7_vty.c
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo_ss7_vty.c b/src/osmo_ss7_vty.c
index 35ee5cd..ec387a9 100644
--- a/src/osmo_ss7_vty.c
+++ b/src/osmo_ss7_vty.c
@@ -864,6 +864,12 @@
 	struct osmo_ss7_routing_key *rkey = &as->cfg.routing_key;
 	int pc;
 
+	if (as->cfg.proto == OSMO_SS7_ASP_PROT_IPA && atoi(rcontext) != 0) {
+		vty_out(vty, "IPA doesn't suppor routing contexts; only permitted routing context "
+			"is 0\n");
+		return CMD_WARNING;
+	}
+
 	pc = osmo_ss7_pointcode_parse(as->inst, dpc);
 	if (pc < 0) {
 		vty_out(vty, "Invalid point code (%s)%s", dpc, VTY_NEWLINE);

-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/15815
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I3f166f44903d0b93963cc5d0cca73d277d2b7215
Gerrit-Change-Number: 15815
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191021/a63cfc0a/attachment.htm>


More information about the gerrit-log mailing list