Change in osmo-bts[master]: vty.c: avoid coverity BAD_SHIFT issues

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Fri Oct 18 12:29:55 UTC 2019


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15806 )

Change subject: vty.c: avoid coverity BAD_SHIFT issues
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bts/+/15806/1/src/common/vty.c 
File src/common/vty.c:

https://gerrit.osmocom.org/c/osmo-bts/+/15806/1/src/common/vty.c@1618 
PS1, Line 1618: (sapi <= 31)
> Why can't we just assert() this?
I'm not so familiar with how coverity works, but if that is enough to make the error go away, then sure. Updated.

(It would be nice if one could test a piece of code against coverity, to see if the issues go away or not.)



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15806
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Id8be0ab67479b1f76a4f624bd3a5242e4fe59f4b
Gerrit-Change-Number: 15806
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-Comment-Date: Fri, 18 Oct 2019 12:29:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <axilirator at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191018/78bea133/attachment.htm>


More information about the gerrit-log mailing list