This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/15793 ) Change subject: vty: Simplify filler burst settings and improve help and readability. ...................................................................... Patch Set 1: (4 comments) https://gerrit.osmocom.org/c/osmo-trx/+/15793/1/CommonLibs/trx_vty.c File CommonLibs/trx_vty.c: https://gerrit.osmocom.org/c/osmo-trx/+/15793/1/CommonLibs/trx_vty.c@a197 PS1, Line 197: test rach-delay <0-68> I understand that these commands are kind of special, and not everybody uses them, but anyway we should not just remove them. Let's rather deprecate them using ALIAS_DEPRECATED or DEFUN_DEPRECATED. https://gerrit.osmocom.org/c/osmo-trx/+/15793/1/CommonLibs/trx_vty.c@a308 PS1, Line 308: trx->cfg.filler = FILLER_EDGE_RAND; Makes sense to send this fix as a separate patch. https://gerrit.osmocom.org/c/osmo-trx/+/15793/1/CommonLibs/trx_vty.c@63 PS1, Line 63: gmsk-rand Just an idea, not a merge blocker: GMSK is used for Access Bursts too. This may be a bit confusing. How about adding a prefix like 'nb-' or 'norm-'? https://gerrit.osmocom.org/c/osmo-trx/+/15793/1/CommonLibs/trx_vty.c@360 PS1, Line 360: rach In general, this parameter has nothing to do with Random Access Channel. Maybe rather rename it to 'access-delay', so then it will be consistent with the values in value_string 'filler_types'? -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15793 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I752eb2c1162d084e8769181f2fcd6c0877663448 Gerrit-Change-Number: 15793 Gerrit-PatchSet: 1 Gerrit-Owner: ipse <Alexander.Chemeris at gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <axilirator at gmail.com> Gerrit-Comment-Date: Tue, 15 Oct 2019 01:56:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191015/ee71fb68/attachment.htm>