Change in osmo-ci[master]: docker: only one apt/pip cmd for installing deps

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Fri Oct 11 11:54:53 UTC 2019


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/15761 )

Change subject: docker: only one apt/pip cmd for installing deps
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-ci/+/15761/2/docker/Dockerfile_osmocom_jenkins.amd64 
File docker/Dockerfile_osmocom_jenkins.amd64:

https://gerrit.osmocom.org/c/osmo-ci/+/15761/2/docker/Dockerfile_osmocom_jenkins.amd64@14 
PS2, Line 14: 		asciidoc \
> damn what a pity […]
This is funny, according to the linked thread, it should *not* work since bash would parse it as one line, probably like this:

 asciidoc-dblatex #Required by osmocom-bb autoconf

However, when I tried it out, it did work. That must be, because the docker parser removes the comments before passing it to the shell.

So I've thought about updating the patch. If we do it like that, we would need to remove the alphabetic order again, and we would basically have the categories of dependencies as we had before. But they don't seem to be so useful to me, we had "generic" dependencies at the top (without any comment), then later "still generic", "building", "and all" which are not meaningful. The others are more or less dependencies for one specific project, but still with either duplicated or an incomplete list of dependencies.

With this in mind, my personal preference would be having this alphabetically sorted list without duplicates, and in the future being able to look at why dependencies were added with git blame.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/15761
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I190e62dd39533b284c93107607dac24ece6d7be6
Gerrit-Change-Number: 15761
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 11 Oct 2019 11:54:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: osmith <osmith at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191011/305ba8ef/attachment.htm>


More information about the gerrit-log mailing list