Change in ...osmo-ccid-firmware[master]: ccid_slot_fsm: Don't free ATR msgb; it is persistent

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Thu Oct 10 13:02:18 UTC 2019


laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/15753


Change subject: ccid_slot_fsm: Don't free ATR msgb; it is persistent
......................................................................

ccid_slot_fsm: Don't free ATR msgb; it is persistent

Change-Id: I2b153c7ad1f40dff946b51d743b2740c4db10dae
---
M ccid_common/ccid_slot_fsm.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/53/15753/1

diff --git a/ccid_common/ccid_slot_fsm.c b/ccid_common/ccid_slot_fsm.c
index 59071de..90899bd 100644
--- a/ccid_common/ccid_slot_fsm.c
+++ b/ccid_common/ccid_slot_fsm.c
@@ -95,7 +95,7 @@
 		resp = ccid_gen_data_block(cs, ss->seq, CCID_CMD_STATUS_OK, 0,
 					   msgb_data(tpdu), msgb_length(tpdu));
 		ccid_slot_send_unbusy(cs, resp);
-		msgb_free(tpdu);
+		/* Don't free "TPDU" here, as the ATR should survive */
 		break;
 	case ISO7816_E_TPDU_DONE_IND:
 		tpdu = data;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/15753
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: I2b153c7ad1f40dff946b51d743b2740c4db10dae
Gerrit-Change-Number: 15753
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191010/869dba87/attachment.htm>


More information about the gerrit-log mailing list