This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/15689 ) Change subject: change IRQ endpoint re-submit logic. ...................................................................... change IRQ endpoint re-submit logic. The interrupt EP is not driven semi-synchronously by reacting to corresponding transfers from the host like the bulk EPs (the SIE will only automagically NAK all IN transfers from the host as long as no data is available), data is instead prepared asynchronously caused by changes to the sim card status, therefore attempting to submit a transfer while the ep is busy should not be an error condition. Change-Id: I41e77eec5f01bf082f8cb7331fbf7baae1c132ed --- M sysmoOCTSIM/main.c 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/sysmoOCTSIM/main.c b/sysmoOCTSIM/main.c index 9ef7f2f..6e2d6ac 100644 --- a/sysmoOCTSIM/main.c +++ b/sysmoOCTSIM/main.c @@ -220,7 +220,9 @@ struct msgb *msg; int rc; - OSMO_ASSERT(!ep_q->in_progress); + if (ep_q->in_progress) + return 0; + msg = msgb_dequeue_irqsafe(&ep_q->list); if (!msg) return 0; @@ -1110,6 +1112,7 @@ while (true) { // main loop command_try_recv(); poll_card_detect(); + submit_next_irq(); osmo_timers_update(); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/15689 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I41e77eec5f01bf082f8cb7331fbf7baae1c132ed Gerrit-Change-Number: 15689 Gerrit-PatchSet: 7 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191010/aba306ac/attachment.htm>