Change in ...osmo-trx[master]: Initial XTRX support

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Wed Oct 9 11:51:40 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/15685 )

Change subject: Initial XTRX support
......................................................................


Patch Set 3:

(3 comments)

Overall looks fine, please clean up small things I pointed out in this version and in first version of the patch,

https://gerrit.osmocom.org/#/c/15685/3/Transceiver52M/device/xtrx/XTRXDevice.cpp 
File Transceiver52M/device/xtrx/XTRXDevice.cpp:

https://gerrit.osmocom.org/#/c/15685/3/Transceiver52M/device/xtrx/XTRXDevice.cpp@38 
PS3, Line 38: // Rx/Tx timestamp difference in samples.
Probably cleaner using /* */


https://gerrit.osmocom.org/#/c/15685/3/Transceiver52M/device/xtrx/XTRXDevice.cpp@459 
PS3, Line 459: 
Remove extra whitespace at the end.


https://gerrit.osmocom.org/#/c/15685/3/contrib/systemd/Makefile.am 
File contrib/systemd/Makefile.am:

https://gerrit.osmocom.org/#/c/15685/3/contrib/systemd/Makefile.am@4 
PS3, Line 4:   osmo-trx-usrp1.service
You miss adding osmo-trx-xtrx.service here.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15685
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I1067dfef53aa2669cc7c189cccae10074c674390
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 3
Gerrit-Owner: rauf.gyulaliev at fairwaves.co
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: ipse <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 09 Oct 2019 11:51:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191009/3352de9c/attachment.htm>


More information about the gerrit-log mailing list