Change in ...osmo-sgsn[master]: gprs_mm_state_gb_fsm: ensure T3350 is not running when entering IDLE

[lynxis lazus]

lynxis lazus has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15486 )

Change subject: gprs_mm_state_gb_fsm: ensure T3350 is not running when entering IDLE
......................................................................

gprs_mm_state_gb_fsm: ensure T3350 is not running when entering IDLE

In IDLE there is not further context with the MS. Prevents the Timer from sending
packages to a MS which can not respond

Change-Id: Ibdd913173af11d0e6d04aa392e047d5d9aee1243
---
M src/sgsn/gprs_mm_state_gb_fsm.c
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  lynxis lazus: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, but someone else must approve



diff --git a/src/sgsn/gprs_mm_state_gb_fsm.c b/src/sgsn/gprs_mm_state_gb_fsm.c
index 4e1ed48..02f6747 100644
--- a/src/sgsn/gprs_mm_state_gb_fsm.c
+++ b/src/sgsn/gprs_mm_state_gb_fsm.c
@@ -20,6 +20,10 @@
 static void st_mm_idle_on_enter(struct osmo_fsm_inst *fi, uint32_t prev_state) {
 	struct sgsn_mm_ctx *ctx = fi->priv;
 
+	/* FIXME: remove this timer when RAU has it's own fsm */
+	if (ctx->T == 3350 && osmo_timer_pending(&ctx->timer))
+		osmo_timer_del(&ctx->timer);
+
 	if (ctx->gb.llme) {
 		gprs_llgmm_unassign(ctx->gb.llme);
 		ctx->gb.llme = NULL;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15486
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Ibdd913173af11d0e6d04aa392e047d5d9aee1243
Gerrit-Change-Number: 15486
Gerrit-PatchSet: 10
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191008/cc87c048/attachment.htm>