Change in ...osmo-ttcn3-hacks[master]: MGCP_Test: Relax expected number of packets in TC_one_crcx_receive_on...

[laforge]

laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15640 )

Change subject: MGCP_Test: Relax expected number of packets in TC_one_crcx_receive_only_rtp
......................................................................

MGCP_Test: Relax expected number of packets in TC_one_crcx_receive_only_rtp

The testcase TC_one_crcx_receive_only_rtp performs a short RTP
transmission that lasts about 1 second. Then it conuts out the number of
packets that are transmitted and checks against a fixed value. The
compare values are determined using experimentation and reflect the
number of bytes/packets that one could expect under normal conditions on
an average machine.

However, there may be load sitations on the test host that may cause that
a too little number of packets is transmitted and the test will fail. Lets
reduce the number a bit as the only thing we want to make sure with this
is that there are at least some (more than one or two) packets transmitted

Change-Id: Ie63445d61268d178940ce8d9cfa984519c42041a
---
M mgw/MGCP_Test.ttcn
1 file changed, 9 insertions(+), 2 deletions(-)

Approvals:
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/mgw/MGCP_Test.ttcn b/mgw/MGCP_Test.ttcn
index 41def03..1a45015 100644
--- a/mgw/MGCP_Test.ttcn
+++ b/mgw/MGCP_Test.ttcn
@@ -1601,10 +1601,17 @@
 
 		stats := f_rtpem_stats_get(RTPEM[0]);
 
-		if (stats.num_pkts_tx < 40) {
+		/* Make sure that at least some amount of RTP packets/bytes
+		 * have has been transmitted. The compare values for
+		 * stats.num_pkts_tx and stats.bytes_payload_tx are determined
+		 * using a testrun and the results were devided by 2, so even
+		 * in load situations we should reach the minimum amount of
+		 * required packets/bytes */
+
+		if (stats.num_pkts_tx < 24) {
 			setverdict(fail);
 		}
-		if (stats.bytes_payload_tx < 190) {
+		if (stats.bytes_payload_tx < 96) {
 			setverdict(fail);
 		}
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15640
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie63445d61268d178940ce8d9cfa984519c42041a
Gerrit-Change-Number: 15640
Gerrit-PatchSet: 5
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191007/dd44cb3f/attachment.htm>