Change in ...osmo-pcu[master]: pcu_l1_if.cpp: Drop unneeded byte in Imm Ass PCH buffer

[laforge]

laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15687 )

Change subject: pcu_l1_if.cpp: Drop unneeded byte in Imm Ass PCH buffer
......................................................................

pcu_l1_if.cpp: Drop unneeded byte in Imm Ass PCH buffer

paging group is 3 bytes and imm assign with plen prepended is 23 bytes,
so there's 1 extra byte not needed and makes code confusing.

Change-Id: Id7835e5aa1506505ff54e019b38f30111f79b5dc
---
M src/pcu_l1_if.cpp
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/src/pcu_l1_if.cpp b/src/pcu_l1_if.cpp
index 6a0d58e..b0dfcc5 100644
--- a/src/pcu_l1_if.cpp
+++ b/src/pcu_l1_if.cpp
@@ -223,7 +223,7 @@
 void pcu_l1if_tx_pch(bitvec * block, int plen, const char *imsi)
 {
 	struct gprs_rlcmac_bts *bts = bts_main_data();
-	uint8_t data[3+1+23]; /* prefix PLEN */
+	uint8_t data[3+23]; /* paging group, prefix PLEN */
 
 	/* paging group */
 	if (!imsi || strlen(imsi) < 3)

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/15687
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Id7835e5aa1506505ff54e019b38f30111f79b5dc
Gerrit-Change-Number: 15687
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191007/7b6def16/attachment.htm>