This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15683 ) Change subject: pcu_l1_if.cpp: Imm Assign PCH: clarify size of different items ...................................................................... Patch Set 1: (5 comments) https://gerrit.osmocom.org/#/c/15683/1/src/pcu_l1_if.cpp File src/pcu_l1_if.cpp: https://gerrit.osmocom.org/#/c/15683/1/src/pcu_l1_if.cpp@a212 PS1, Line 212: Unrelated ws fix. https://gerrit.osmocom.org/#/c/15683/1/src/pcu_l1_if.cpp@226 PS1, Line 226: 1 + 22 I would not separate PLEN from Immediate Assignment, it's a mandatory part of that message. To me 3 + 23 looks cleaner, because I know that 23 is the default GSM MAC block length. Moreover, I would use GSM_MACBLOCK_LEN macro here. https://gerrit.osmocom.org/#/c/15683/1/src/pcu_l1_if.cpp@237 PS1, Line 237: 3 + 1 Here it's logical (maybe worth adding a comment): we skip 3 octets of paging group, and the first octet of the MAC block (Immediate Assignment message), because bitvec_pack() does not write plen for us. https://gerrit.osmocom.org/#/c/15683/1/src/pcu_l1_if.cpp@241 PS1, Line 241: 1 + 22 GSM_MACBLOCK_LEN https://gerrit.osmocom.org/#/c/15683/1/src/pcu_l1_if.cpp@243 PS1, Line 243: 1 + 22 GSM_MACBLOCK_LEN -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/15683 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I32876858e3e93951e965b0fc7875c95c1f36f3ac Gerrit-Change-Number: 15683 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <axilirator at gmail.com> Gerrit-Comment-Date: Mon, 07 Oct 2019 16:45:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191007/f1e9178c/attachment.htm>