Change in ...osmo-bts[master]: bts-trx: Don't reset transceiver_available in scheduler_trx.c

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Sat Oct 5 20:50:16 UTC 2019


pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bts/+/15630 )

Change subject: bts-trx: Don't reset transceiver_available in scheduler_trx.c
......................................................................

bts-trx: Don't reset transceiver_available in scheduler_trx.c

It can be dropped since bts_shutdown() ends up calling immediatelly
bts_model_trx_close() which in turn calls bts_model_trx_close() which
sets enabled = false and calls l1if_provision_transceiver_trx() to
power off the TRX.

Related: OS#4215
Change-Id: If8b3d2379d7ae102e1c338f4558ac1352de761cc
---
M src/osmo-bts-trx/scheduler_trx.c
1 file changed, 0 insertions(+), 3 deletions(-)

Approvals:
  laforge: Looks good to me, but someone else must approve
  fixeria: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bts-trx/scheduler_trx.c b/src/osmo-bts-trx/scheduler_trx.c
index ac34a11..b3b656a 100644
--- a/src/osmo-bts-trx/scheduler_trx.c
+++ b/src/osmo-bts-trx/scheduler_trx.c
@@ -1678,10 +1678,7 @@
 
 no_clock:
 	osmo_timerfd_disable(&tcs->fn_timer_ofd);
-	transceiver_available = 0;
-
 	bts_shutdown(bts, "No clock from osmo-trx");
-
 	return -1;
 }
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15630
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: If8b3d2379d7ae102e1c338f4558ac1352de761cc
Gerrit-Change-Number: 15630
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191005/f54f5d76/attachment.htm>


More information about the gerrit-log mailing list