This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15627 ) Change subject: bts-trx: vty: Print phy link state in cmd 'show transceiver' ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/15627/1/src/common/phy_link.c File src/common/phy_link.c: https://gerrit.osmocom.org/#/c/15627/1/src/common/phy_link.c@84 PS1, Line 84: phy_link_state_get What is the point? Just a function to get field's value, that can be accessed directly? I am definitely against this 'helper'. https://gerrit.osmocom.org/#/c/15627/1/src/osmo-bts-trx/trx_vty.c File src/osmo-bts-trx/trx_vty.c: https://gerrit.osmocom.org/#/c/15627/1/src/osmo-bts-trx/trx_vty.c@78 PS1, Line 78: phy_link_state_get(plink) You can access the field directly: plink->state. It's even shorter. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15627 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I8e49f8edad9f9c68d110dbb7faeea5143aa91022 Gerrit-Change-Number: 15627 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-CC: fixeria <axilirator at gmail.com> Gerrit-Comment-Date: Sat, 05 Oct 2019 11:30:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191005/9a67c2d9/attachment.htm>