This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15676 ) Change subject: pcu: Introduce test TC_t3169 ...................................................................... Patch Set 2: (8 comments) https://gerrit.osmocom.org/#/c/15676/2/library/RLCMAC_Types.ttcn File library/RLCMAC_Types.ttcn: https://gerrit.osmocom.org/#/c/15676/2/library/RLCMAC_Types.ttcn@309 PS2, Line 309: tr_RLCMAC_DUMMY_CTRL Cool! Very useful template. https://gerrit.osmocom.org/#/c/15676/2/library/RLCMAC_Types.ttcn@315 PS2, Line 315: usf := ? I know you may not need this in you test case scenarios, but please parametrize this field. It will definitely be needed soon. https://gerrit.osmocom.org/#/c/15676/2/pcu/PCU_Tests_RAW.ttcn File pcu/PCU_Tests_RAW.ttcn: https://gerrit.osmocom.org/#/c/15676/2/pcu/PCU_Tests_RAW.ttcn@617 PS2, Line 617: pcuif_ BTW: regarding this prefix, we're not dealing with the PCU interface directly anymore. Let's avoid it? Not a merge blocker though. https://gerrit.osmocom.org/#/c/15676/2/pcu/PCU_Tests_RAW.ttcn@628 PS2, Line 628: /* 16 UL blocks (0 .. 32 dB, step = 2 dB) */ Copy-pasted, please dd. https://gerrit.osmocom.org/#/c/15676/2/pcu/PCU_Tests_RAW.ttcn@631 PS2, Line 631: countdown := (num_blocks - i) Keep in mind, this is a countdown. If you're sending only one block, it shall be set to 0 (no more blocks pending). With this code, OsmoPCU will always expect one more UL block. https://gerrit.osmocom.org/#/c/15676/2/pcu/PCU_Tests_RAW.ttcn@658 PS2, Line 658: f_rx_pcuif_rlcmac_dl_block_exp_dummy Same comment as for 15675, do we really need to create functions for such basic things? IMHO, this decreases readability: one would have to jump between different helper definitions while reading the code. https://gerrit.osmocom.org/#/c/15676/2/pcu/PCU_Tests_RAW.ttcn@1003 PS2, Line 1003: 1 You may need to change this to 2 as soon as you fix the countdown calculation in f_tx_pcuif_rlcmac_ul_n_blocks(). https://gerrit.osmocom.org/#/c/15676/2/pcu/PCU_Tests_RAW.ttcn@1010 PS2, Line 1010: f_tx_pcuif_rlcmac_ul_n_blocks ... and this call can also be removed then. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15676 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I587413a7de7956daee3423057530e4052a55ba88 Gerrit-Change-Number: 15676 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 04 Oct 2019 19:55:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191004/ec8d3c32/attachment.htm>