This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15675 ) Change subject: pcu: Introduce func helper f_establish_tbf_ul() ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/15675/1/pcu/PCU_Tests_RAW.ttcn File pcu/PCU_Tests_RAW.ttcn: https://gerrit.osmocom.org/#/c/15675/1/pcu/PCU_Tests_RAW.ttcn@566 PS1, Line 566: f_establish_tbf_ul I am not against helper functions in TTCN-3, but sometimes it feels like we're loosing flexibility. And in the end it turns that one helper is calling another helper with calls some other helpers. On the other hand, I am also agree that we need to avoid code duplication. My suggestion is this particular case is to keep TBF establishment aside, and only check if the received Immediate Assignment (first 'in' parameter) is an Uplink TBF assignment (implemented starting from line "Make sure we received an UL TBF Assignment"). This way we avoid duplication of the arguments of f_establish_tbf(). https://gerrit.osmocom.org/#/c/15675/1/pcu/PCU_Tests_RAW.ttcn@578 PS1, Line 578: ? This can then be parametrized too, so there would be no need to check if it's a dynamic allocation or not (see below). If some test case would need a Single Block Assignment, it will just pass the corresponding template as a parameter. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15675 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5b8a7ca5a4d0f905bf68949978811b139568c237 Gerrit-Change-Number: 15675 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 04 Oct 2019 19:35:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191004/be2e5cbf/attachment.htm>