Change in ...osmo-ttcn3-hacks[master]: pcu: Allow tests to overwrite pcuif INFO_IND params

[fixeria]

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15674 )

Change subject: pcu: Allow tests to overwrite pcuif INFO_IND params
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

https://gerrit.osmocom.org/#/c/15674/1/pcu/PCU_Tests_RAW.ttcn 
File pcu/PCU_Tests_RAW.ttcn:

https://gerrit.osmocom.org/#/c/15674/1/pcu/PCU_Tests_RAW.ttcn@a462 
PS1, Line 462: 
So this comment is removed (actually not moved), but we still using hard-coded parameters? Please keep it.


https://gerrit.osmocom.org/#/c/15674/1/pcu/PCU_Tests_RAW.ttcn@72 
PS1, Line 72: f_default_pcuif_info_ind
You can do this without a function, just define a global constant instead:

  const PCUIF_info_ind default_info_ind := { ... };

so then it can be tuned by copying to a variable:

  var PCUIF_info_ind info_ind := default_info_ind;
  info_ind.foo := BAR;


https://gerrit.osmocom.org/#/c/15674/1/pcu/PCU_Tests_RAW.ttcn@114 
PS1, Line 114: f_init_pcuif
Not sure if this function really needs to be changed. The new test cases should be based on top of the new components, while the existing test cases do not require us to pass different INFO.ind.


https://gerrit.osmocom.org/#/c/15674/1/pcu/PCU_Tests_RAW.ttcn@484 
PS1, Line 484: template (omit) PCUIF_info_ind info_ind_tpl := omit
So then you will not need this ugly template-omit hack:

  ..., PCUIF_info_ind := default_info_ind);



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15674
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I75c746b822184fdcc966d77a7c6a0a6918c236e6
Gerrit-Change-Number: 15674
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 04 Oct 2019 18:51:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191004/88b09a18/attachment.htm>