Change in ...osmo-ttcn3-hacks[master]: MSC_Tests.ttcn: fix race condition in f_tc_proc_ss_paging_fail()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Fri Oct 4 16:20:13 UTC 2019


laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15648 )

Change subject: MSC_Tests.ttcn: fix race condition in f_tc_proc_ss_paging_fail()
......................................................................

MSC_Tests.ttcn: fix race condition in f_tc_proc_ss_paging_fail()

Sometimes in TC_proc_ss_paging_fail we hit a race condition. The
problem is that the paging expiration timer in OsmoMSC is set to
10 seconds by default (see MSC_PAGING_RESPONSE_TIMER_DEFAULT),
and in f_tc_proc_ss_paging_fail() we also wait 10.0 seconds.

Let's increase our timer value to 20.0 seconds,
so there will be more 10 seconds of leeway.

Change-Id: I6983e8c0cc8e1d7d1619f127e80063d71a4759d2
Related: Jenkins ttcn3-msc-test build #677
---
M msc/MSC_Tests.ttcn
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn
index 0d54405..fbb471e 100644
--- a/msc/MSC_Tests.ttcn
+++ b/msc/MSC_Tests.ttcn
@@ -3705,8 +3705,9 @@
 		}
 	}
 
-	/* Expect GSUP PROC_SS_ERROR message */
-	f_expect_gsup_msg(gsup_rsp, T_val := 10.0);
+	/* Wait up to 20 seconds for GSUP PROC_SS_ERROR message.
+	 * OsmoMSC waits for Paging Response 10 seconds by default. */
+	f_expect_gsup_msg(gsup_rsp, T_val := 20.0);
 }
 testcase TC_proc_ss_paging_fail() runs on MTC_CT {
 	var BSC_ConnHdlr vc_conn;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15648
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I6983e8c0cc8e1d7d1619f127e80063d71a4759d2
Gerrit-Change-Number: 15648
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191004/71faf38f/attachment.htm>


More information about the gerrit-log mailing list