Change in ...osmo-ttcn3-hacks[master]: library/PCUIF_Types.ttcn: add optional parameter for RACH SAPI

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Fri Oct 4 15:47:55 UTC 2019


laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15671 )

Change subject: library/PCUIF_Types.ttcn: add optional parameter for RACH SAPI
......................................................................

library/PCUIF_Types.ttcn: add optional parameter for RACH SAPI

Do not hard-code PCU_IF_SAPI_RACH for RACH.ind templates. We need
to be able to specify other SAPIs (PCU_IF_SAPI_PTCCH) in the
upcoming test cases for Timing Advance control.

Change-Id: I7e2ebcbba5e47cf44f064e429c0517ef3acb15af
---
M library/PCUIF_Types.ttcn
1 file changed, 6 insertions(+), 4 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved
  laforge: Looks good to me, approved



diff --git a/library/PCUIF_Types.ttcn b/library/PCUIF_Types.ttcn
index bcd9066..a36e261 100644
--- a/library/PCUIF_Types.ttcn
+++ b/library/PCUIF_Types.ttcn
@@ -570,14 +570,15 @@
 						 template (value) PCUIF_BurstType burst_type,
 						 template (value) uint32_t fn,
 						 template (value) uint16_t arfcn,
-						 template (value) int16_t qta := 0
+						 template (value) int16_t qta := 0,
+						 template (value) PCUIF_Sapi sapi := PCU_IF_SAPI_RACH
 ) := {
 	msg_type := PCU_IF_MSG_RACH_IND,
 	bts_nr := bts_nr,
 	spare := '0000'O,
 	u := {
 		rach_ind := {
-			sapi := PCU_IF_SAPI_RACH,
+			sapi := sapi,
 			ra := ra,
 			qta := qta,
 			fn := fn,
@@ -591,13 +592,14 @@
 					 template uint16_t ra := ?,
 					 template uint8_t is_11bit := ?,
 					 template PCUIF_BurstType burst_type := ?,
-					 template uint32_t fn := ?) := {
+					 template uint32_t fn := ?,
+					 template PCUIF_Sapi sapi := PCU_IF_SAPI_RACH) := {
 	msg_type := PCU_IF_MSG_RACH_IND,
 	bts_nr := bts_nr,
 	spare := ?,
 	u := {
 		rach_ind := {
-			sapi := PCU_IF_SAPI_RACH,
+			sapi := sapi,
 			ra := ra,
 			qta := ?,
 			fn := fn,

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15671
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I7e2ebcbba5e47cf44f064e429c0517ef3acb15af
Gerrit-Change-Number: 15671
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191004/96fcd27b/attachment.htm>


More information about the gerrit-log mailing list