Change in ...osmo-bts[master]: scheduler: fix handling of PTCCH/U and PTCCH/D logical channels

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Wed Oct 2 16:50:54 UTC 2019


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15656 )

Change subject: scheduler: fix handling of PTCCH/U and PTCCH/D logical channels
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/15656/1/src/common/l1sap.c 
File src/common/l1sap.c:

https://gerrit.osmocom.org/#/c/15656/1/src/common/l1sap.c@1320 
PS1, Line 1320: 		pcu_tx_rach_ind(bts, rach_ind->acc_delay_256bits >> 6,
> Why >> 6 here?
Because 6 is a power of 2: 2 ^ 6 is 64.
X >> 6 gives us same result as X / 64.

See another example below: X << 2 is equivalent to X * 4.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15656
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I232e5f514fbad2c51daaa59ff516004aba97c8a3
Gerrit-Change-Number: 15656
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 02 Oct 2019 16:50:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191002/47e492f1/attachment.htm>


More information about the gerrit-log mailing list