This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/16350 ) Change subject: abis_nm.c: fix RSL connection temeout for trx->nr > 0 ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/16350/1/src/osmo-bsc/abis_nm.c File src/osmo-bsc/abis_nm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/16350/1/src/osmo-bsc/abis_nm.c@2705 PS1, Line 2705: trx = gsm_bts_trx_by_nr(sign_link->trx->bts, foh->obj_inst.trx_nr); Probably better deferring using foh stuff after the verifications done in line 2707. https://gerrit.osmocom.org/c/osmo-bsc/+/16350/1/src/osmo-bsc/abis_nm.c@2743 PS1, Line 2743: if (trx == NULL) Usually better using !trx for pointers. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/16350 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib4b9a198da11c88a51cfa78ffb7e7235a6365ef4 Gerrit-Change-Number: 16350 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <axilirator at gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Sat, 30 Nov 2019 23:31:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191130/46628ee9/attachment.htm>