Change in osmo-pcu[master]: VTY: get rid of pcu_vty_go_parent() / pcu_vty_is_config_node()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Sat Nov 30 13:27:53 UTC 2019


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/16347 )


Change subject: VTY: get rid of pcu_vty_go_parent() / pcu_vty_is_config_node()
......................................................................

VTY: get rid of pcu_vty_go_parent() / pcu_vty_is_config_node()

Since I2b32b4fe20732728db6e9cdac7e484d96ab86dc5, go_parent_cb()
is completely optional. It no longer has the task to determine
the correct parent node. The is_config_node() callback is no
longer needed too. Get rid of them.

Change-Id: Id7ce8c4e1ac43747ad40a06d01433c366da07b42
---
M src/pcu_vty.c
1 file changed, 0 insertions(+), 31 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/47/16347/1

diff --git a/src/pcu_vty.c b/src/pcu_vty.c
index afc8a9b..d716a9a 100644
--- a/src/pcu_vty.c
+++ b/src/pcu_vty.c
@@ -91,35 +91,6 @@
 	return CMD_SUCCESS;
 }
 
-
-int pcu_vty_go_parent(struct vty *vty)
-{
-	switch (vty->node) {
-#if 0
-	case TRX_NODE:
-		vty->node = PCU_NODE;
-		{
-			struct gsm_bts_trx *trx = vty->index;
-			vty->index = trx->bts;
-		}
-		break;
-#endif
-	default:
-		vty->node = CONFIG_NODE;
-	}
-	return (enum node_type) vty->node;
-}
-
-int pcu_vty_is_config_node(struct vty *vty, int node)
-{
-	switch (node) {
-	case PCU_NODE:
-		return 1;
-	default:
-		return 0;
-	}
-}
-
 static struct cmd_node pcu_node = {
 	(enum node_type) PCU_NODE,
 	"%s(config-pcu)# ",
@@ -1218,8 +1189,6 @@
 	.name		= "Osmo-PCU",
 	.version	= PACKAGE_VERSION,
 	.copyright	= pcu_copyright,
-	.go_parent_cb	= pcu_vty_go_parent,
-	.is_config_node	= pcu_vty_is_config_node,
 };
 
 int pcu_vty_init(void)

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/16347
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Id7ce8c4e1ac43747ad40a06d01433c366da07b42
Gerrit-Change-Number: 16347
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191130/5f07857e/attachment.htm>


More information about the gerrit-log mailing list