Change in osmo-pcu[master]: VTY: add warning about changing PCU socket path at run-time

[fixeria]

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/16345 )


Change subject: VTY: add warning about changing PCU socket path at run-time
......................................................................

VTY: add warning about changing PCU socket path at run-time

Change-Id: I7cee2d782bd3dfc2cc8d2febc16dca905dcc294e
---
M src/pcu_vty.c
1 file changed, 3 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/45/16345/1

diff --git a/src/pcu_vty.c b/src/pcu_vty.c
index 2fd57d0..1f46707 100644
--- a/src/pcu_vty.c
+++ b/src/pcu_vty.c
@@ -1097,12 +1097,13 @@
 {
 	struct gprs_rlcmac_bts *bts = bts_main_data();
 
+	if (vty->type != VTY_FILE)
+		vty_out(vty, "Changing PCU socket path at run-time has no effect%s", VTY_NEWLINE);
+
 	if (bts->pcu_sock_path) {
-		/* FIXME: close the interface? */
 		talloc_free(bts->pcu_sock_path);
 	}
 	bts->pcu_sock_path = talloc_strdup(tall_pcu_ctx, argv[0]);
-	/* FIXME: re-open the interface? */
 
 	return CMD_SUCCESS;
 }

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/16345
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I7cee2d782bd3dfc2cc8d2febc16dca905dcc294e
Gerrit-Change-Number: 16345
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191130/c48d8f73/attachment.htm>