Change in osmo-hlr[master]: refactor: add and use lu_fsm, osmo_gsup_req, osmo_gt

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sat Nov 30 10:07:23 UTC 2019


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16205 )

Change subject: refactor: add and use lu_fsm, osmo_gsup_req, osmo_gt
......................................................................


Patch Set 19:

(2 comments)

Please add an osmocom issue about the missing cancel to old vlr/sgsn

https://gerrit.osmocom.org/c/osmo-hlr/+/16205/19/include/osmocom/gsupclient/global_title.h 
File include/osmocom/gsupclient/global_title.h:

https://gerrit.osmocom.org/c/osmo-hlr/+/16205/19/include/osmocom/gsupclient/global_title.h@13 
PS19, Line 13:  * GNU Affero General Public License for more details.
gsupclient is not agpl so far, please don't change it


https://gerrit.osmocom.org/c/osmo-hlr/+/16205/19/include/osmocom/gsupclient/global_title.h@30 
PS19, Line 30: struct osmo_gt {
Please don't cdall it osmo_gt. We already have real global titles in libosmo-sccp, and given that we still don't handle them here just causes more confusio. Maybe something like osmo_gsup_id with a union that only contains the opaque buffer for now?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16205
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I3a8dff3d4a1cbe10d6ab08257a0138d6b2a082d9
Gerrit-Change-Number: 16205
Gerrit-PatchSet: 19
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Sat, 30 Nov 2019 10:07:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191130/71178f9e/attachment.htm>


More information about the gerrit-log mailing list