Change in osmo-hlr[master]: add libosmo-mslookup abstract client

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sat Nov 30 09:47:10 UTC 2019


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16202 )

Change subject: add libosmo-mslookup abstract client
......................................................................


Patch Set 16: Code-Review-1

(4 comments)

https://gerrit.osmocom.org/c/osmo-hlr/+/16202/16/include/osmocom/mslookup/mslookup.h 
File include/osmocom/mslookup/mslookup.h:

https://gerrit.osmocom.org/c/osmo-hlr/+/16202/16/include/osmocom/mslookup/mslookup.h@16 
PS16, Line 16:  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
We may want to consider more permissive licensing for the library. libosmo-gsupclient is under GPLv2+, and I would go at least for that here, maybe even LGPL for both libraries (,that could be a future change).


https://gerrit.osmocom.org/c/osmo-hlr/+/16202/16/include/osmocom/mslookup/mslookup_client.h 
File include/osmocom/mslookup/mslookup_client.h:

https://gerrit.osmocom.org/c/osmo-hlr/+/16202/16/include/osmocom/mslookup/mslookup_client.h@64 
PS16, Line 64: 	uint32_t min_delay_milliseconds;
Delay somehow impkies busy waiting. let's call it wait or possibly sleep?


https://gerrit.osmocom.org/c/osmo-hlr/+/16202/16/src/mslookup/mslookup.c 
File src/mslookup/mslookup.c:

https://gerrit.osmocom.org/c/osmo-hlr/+/16202/16/src/mslookup/mslookup.c@89 
PS16, Line 89:  */
Very complete docs!


https://gerrit.osmocom.org/c/osmo-hlr/+/16202/16/src/mslookup/mslookup.c@197 
PS16, Line 197: size_t osmo_mslookup_result_name_buf(char *buf, size_t buflen,
On a again (just had this with another patch): the name of a message is what we have in value_str. You are generating a description or a string representation here, so _descr or _strrep or _stringify might be more appropriate.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16202
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I83487ab8aad1611eb02e997dafbcb8344da13df1
Gerrit-Change-Number: 16202
Gerrit-PatchSet: 16
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sat, 30 Nov 2019 09:47:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191130/e890638e/attachment.htm>


More information about the gerrit-log mailing list