Change in osmo-msc[master]: add sdp_msg API: SDP parsing/composition

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Thu Nov 28 15:22:07 UTC 2019


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15947 )

Change subject: add sdp_msg API: SDP parsing/composition
......................................................................


Patch Set 4: Code-Review+2

(1 comment)

combining 2x +1

https://gerrit.osmocom.org/c/osmo-msc/+/15947/3/src/libmsc/sdp_msg.c 
File src/libmsc/sdp_msg.c:

https://gerrit.osmocom.org/c/osmo-msc/+/15947/3/src/libmsc/sdp_msg.c@511 
PS3, Line 511: 	if (codec->fmtp[0])
> is this a check against != '\0' ?
yes, a check for != '\0'



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15947
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: If3ce23cd5bab15e2ab4c52ef3e4c75979dffe931
Gerrit-Change-Number: 15947
Gerrit-PatchSet: 4
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 28 Nov 2019 15:22:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191128/05eac057/attachment.htm>


More information about the gerrit-log mailing list