Change in osmo-ttcn3-hacks[master]: library/MNCC_Types: fix sdp in tr_MNCC_*

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Thu Nov 28 14:39:06 UTC 2019


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16314 )

Change subject: library/MNCC_Types: fix sdp in tr_MNCC_*
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16314/1//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16314/1//COMMIT_MSG@25 
PS1, Line 25: 13:15:27.516604 5 SIP_Tests.ttcn:221 Matching on port MNCC .u.rtp.sdp := "0" with "" unmatched: First message in the queue does not match the template:
> is "0" actually a correct SDP message? or is it some length inside a string? that looks confusing.
This is the output from the TTCN-3 testsuite. My understanding is, that osmo-sip-connector does not send the SDP data before [1] is merged, therefore the information is empty. I don't know why it is displayed here as "0".

But that should not be relevant for the patch, which fixes up a previous patch [2] where all tr_MNCC_* templates have sdp := *, except for these three, and it's clear that the intention was to do this for all such tr_MNCC_* templates.

[1] https://gerrit.osmocom.org/c/osmo-sip-connector/+/16222
[2] https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16032



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16314
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic7a2df0b6faeaa88682880f816518618ced79a7e
Gerrit-Change-Number: 16314
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 28 Nov 2019 14:39:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191128/24c1910c/attachment.htm>


More information about the gerrit-log mailing list