Change in osmo-ccid-firmware[master]: pps warning

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Hoernchen gerrit-no-reply at lists.osmocom.org
Wed Nov 27 18:44:13 UTC 2019


Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16286 )


Change subject: pps warning
......................................................................

pps warning

Change-Id: Ia125b7983e81342af224bc6e8771d8be4c4bfa42
---
M ccid_common/ccid_slot_fsm.c
1 file changed, 7 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/86/16286/1

diff --git a/ccid_common/ccid_slot_fsm.c b/ccid_common/ccid_slot_fsm.c
index d7740fe..fef1515 100644
--- a/ccid_common/ccid_slot_fsm.c
+++ b/ccid_common/ccid_slot_fsm.c
@@ -188,6 +188,13 @@
 		uint8_t D = iso7816_3_di_table[cs->proposed_pars.di];
 		uint32_t fmax = iso7816_3_fmax_table[cs->proposed_pars.fi];
 
+		/* 7816-3 5.2.3
+		 * No  information  shall  be  exchanged  when  switching  the
+		 * frequency  value.  Two  different  times  are  recommended
+		 * for switching the frequency value, either
+		 * - after ATR while card is idle
+		 * - after PPS while card is idle
+		 */
 		card_uart_ctrl(ss->cuart, CUART_CTL_CLOCK_FREQ, fmax);
 		card_uart_ctrl(ss->cuart, CUART_CTL_FD, F/D);
 		card_uart_ctrl(ss->cuart, CUART_CTL_WTIME, cs->proposed_pars.t0.waiting_integer);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16286
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: Ia125b7983e81342af224bc6e8771d8be4c4bfa42
Gerrit-Change-Number: 16286
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191127/7b785841/attachment.htm>


More information about the gerrit-log mailing list