Change in libosmocore[master]: add osmo_gsup_make_response() and osmo_gsup_message_name_*()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Wed Nov 27 08:47:37 UTC 2019


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16189 )

Change subject: add osmo_gsup_make_response() and osmo_gsup_message_name_*()
......................................................................


Patch Set 3:

(3 comments)

https://gerrit.osmocom.org/c/libosmocore/+/16189/3/src/gsm/gsup.c 
File src/gsm/gsup.c:

https://gerrit.osmocom.org/c/libosmocore/+/16189/3/src/gsm/gsup.c@910 
PS3, Line 910:  * Note: after calling this function, fields in the reply may reference the same memory as rx and are not deep-copied.
> I see no deep-copied as a source of problems. […]
Ack


https://gerrit.osmocom.org/c/libosmocore/+/16189/3/src/gsm/gsup.c@943 
PS3, Line 943: 	if (!reply->imsi[0])
> I'll keep asking to please match against = '\0', it's then clear from reader point of view that this […]
Ack


https://gerrit.osmocom.org/c/libosmocore/+/16189/3/src/gsm/gsup.c@1040 
PS3, Line 1040: 	OSMO_NAME_C_IMPL(ctx, 64, "ERROR", osmo_gsup_message_name_buf, msg)
> 64 looks a bit small here given the amount of text above. […]
Ack



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/16189
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Id9692880079ea0f219f52d81b1923a76fc640566
Gerrit-Change-Number: 16189
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 27 Nov 2019 08:47:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191127/8b1dc6e7/attachment.htm>


More information about the gerrit-log mailing list