Change in libosmocore[master]: libosmovty: simplify condition checking vty->fd in vty_close()

[neels]

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16149 )

Change subject: libosmovty: simplify condition checking vty->fd in vty_close()
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/16149/1/src/vty/vty.c 
File src/vty/vty.c:

https://gerrit.osmocom.org/c/libosmocore/+/16149/1/src/vty/vty.c@235 
PS1, Line 235: 	if (vty->fd > 2) {
I kind of prefer the explicit mention of 'stderr', it makes abundantly clear what the condition is doing. If we need stdin and stdout as well, I'd rather add 'vty->fd != fileno(stdout)' as well.
But in fact, we will never have an fd on stdout because there is no 'log stdout' VTY command.
And for obious reasons no vty fd will ever be == fileno(stdin).
So I see what this is about, but my bikeshed is: just keep the previous version :P



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/16149
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ied35d142af0ba0f5ad78975b8f22c35b32d6ff71
Gerrit-Change-Number: 16149
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Tue, 26 Nov 2019 03:28:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191126/8d52d960/attachment.htm>