This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/15916 ) Change subject: add osmo_gsup_conn_send_err_reply() ...................................................................... Patch Set 8: (3 comments) (submitting old comments I forgot to submit) https://gerrit.osmocom.org/c/osmo-hlr/+/15916/2/src/gsup_server.c File src/gsup_server.c: https://gerrit.osmocom.org/c/osmo-hlr/+/15916/2/src/gsup_server.c@66 PS2, Line 66: only REQUESTs need an error reply > Probably, makes sense to print a warning then. so far calling code does this if(), maybe is more obvious to keep it that way? I don't think we need to send a warning if we don't need to answer. https://gerrit.osmocom.org/c/osmo-hlr/+/15916/2/src/gsup_server.c@88 PS2, Line 88: OSMO_ASSERT > osmo_gsup_msgb_alloc() also assert()s the result of allocation, so this is redundant. thx https://gerrit.osmocom.org/c/osmo-hlr/+/15916/2/src/gsup_server.c@89 PS2, Line 89: osmo_gsup_encode > Should we check if encoding failed? hmm, I think we could entirely drop the return code and all, because: if I am trying to send an error response, but sending the error response fails, then what can I do? Pretty much nothing at all, we're stuffed on top of an error anyway. But yes, would be good to log the error at least. -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/15916 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I792fd9993ab2a323af58782a357d71205c43b72a Gerrit-Change-Number: 15916 Gerrit-PatchSet: 8 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-CC: fixeria <axilirator at gmail.com> Gerrit-Comment-Date: Mon, 25 Nov 2019 21:57:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <axilirator at gmail.com> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191125/f37584ea/attachment.htm>