Change in libosmocore[master]: vty_app_info.is_config_node: add OSMO_DEPRECATED

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Sun Nov 24 19:01:33 UTC 2019


neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/16188 )


Change subject: vty_app_info.is_config_node: add OSMO_DEPRECATED
......................................................................

vty_app_info.is_config_node: add OSMO_DEPRECATED

Although this OSMO_DEPRECATED doesn't seem to generate a warning when compiling
code that sets .is_config_node = foo, it seems a good idea to add the
deprecation tag.

It is deprecated since commit "vty: track parent nodes also for telnet sessions"
I2b32b4fe20732728db6e9cdac7e484d96ab86dc5

Change-Id: I800507b27cb0d536c1a4c203d7f7b90eec05a69c
---
M include/osmocom/vty/vty.h
1 file changed, 4 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/88/16188/1

diff --git a/include/osmocom/vty/vty.h b/include/osmocom/vty/vty.h
index 9acaa7d..b63dc3b 100644
--- a/include/osmocom/vty/vty.h
+++ b/include/osmocom/vty/vty.h
@@ -5,6 +5,7 @@
 #include <stdbool.h>
 
 #include <osmocom/core/linuxlist.h>
+#include <osmocom/core/defs.h>
 
 /*! \defgroup vty VTY (Virtual TTY) interface
  *  @{
@@ -186,7 +187,9 @@
 	int (*go_parent_cb)(struct vty *vty);
 	/*! OBSOLETED: Implicit parent node tracking has replaced the use of this callback. This callback is no longer
 	 * called, ever, and can be left NULL. */
-	int (*is_config_node)(struct vty *vty, int node);
+	int (*is_config_node)(struct vty *vty, int node)
+		OSMO_DEPRECATED("Implicit parent node tracking has replaced the use of this callback. This callback is"
+				" no longer called, ever, and can be left NULL.");
 	/*! Check if the config is consistent before write */
 	int (*config_is_consistent)(struct vty *vty);
 };

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/16188
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I800507b27cb0d536c1a4c203d7f7b90eec05a69c
Gerrit-Change-Number: 16188
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191124/74601dca/attachment.htm>


More information about the gerrit-log mailing list