This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/12224 ) Change subject: Use libosmocore constant for IMSI length in ACL entry ...................................................................... Use libosmocore constant for IMSI length in ACL entry Presumably the length is chosen to match that of imsi in osmo_gsup_message. Change-Id: I138aea409aab0c748c75546e628797fc7498bf40 --- M include/osmocom/sgsn/gprs_sgsn.h 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved laforge: Looks good to me, approved diff --git a/include/osmocom/sgsn/gprs_sgsn.h b/include/osmocom/sgsn/gprs_sgsn.h index 0886ce7..289e0c4 100644 --- a/include/osmocom/sgsn/gprs_sgsn.h +++ b/include/osmocom/sgsn/gprs_sgsn.h @@ -428,7 +428,7 @@ */ struct imsi_acl_entry { struct llist_head list; - char imsi[16+1]; + char imsi[OSMO_IMSI_BUF_SIZE]; }; /* see GSM 09.02, 17.7.1, PDP-Context and GPRSSubscriptionData */ -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/12224 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I138aea409aab0c748c75546e628797fc7498bf40 Gerrit-Change-Number: 12224 Gerrit-PatchSet: 5 Gerrit-Owner: Max <suraev at alumni.ntnu.no> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <suraev at alumni.ntnu.no> Gerrit-Reviewer: Stefan Sperling <stsp at stsp.name> Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: msuraev <suraev at alumni.ntnu.no> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191123/79275bc4/attachment.htm>