Change in libosmocore[master]: logging/vty: fix: do not close stderr in vty_close()

[fixeria]

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16144 )

Change subject: logging/vty: fix: do not close stderr in vty_close()
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/16144/1/src/vty/vty.c 
File src/vty/vty.c:

https://gerrit.osmocom.org/c/libosmocore/+/16144/1/src/vty/vty.c@234 
PS1, Line 234: 	if (vty->fd > 0 && vty->fd != fileno(stderr)) {
> what about simply checking "vty->fd > 2" ?
I was thinking about this. Is it guaranteed that stdout is fd=1 and stderr is fd=2 on all platforms?



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/16144
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I6ecc85555d102f5911d50ed5ac54933c766fa84d
Gerrit-Change-Number: 16144
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 21 Nov 2019 11:49:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191121/20bd379f/attachment.htm>