This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/16144 ) Change subject: logging/vty: fix: do not close stderr in vty_close() ...................................................................... logging/vty: fix: do not close stderr in vty_close() Since Icdeaea67a06da3a2f07b252e455629559ecc1829, we use stderr for printing warnings while parsing the VTY configuration files. Make sure we do not close() stderr. Otherwise stderr logging gets broken. Change-Id: I6ecc85555d102f5911d50ed5ac54933c766fa84d Fixes: Icdeaea67a06da3a2f07b252e455629559ecc1829 --- M src/vty/vty.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/44/16144/1 diff --git a/src/vty/vty.c b/src/vty/vty.c index 3357d5a..cd252ad 100644 --- a/src/vty/vty.c +++ b/src/vty/vty.c @@ -231,7 +231,7 @@ vector_unset(vtyvec, vty->fd); /* Close socket. */ - if (vty->fd > 0) { + if (vty->fd > 0 && vty->fd != fileno(stderr)) { close(vty->fd); vty->fd = -1; } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/16144 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6ecc85555d102f5911d50ed5ac54933c766fa84d Gerrit-Change-Number: 16144 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <axilirator at gmail.com> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191121/01ed252e/attachment.htm>