Change in libosmocore[master]: logging/vty: do not print deprecated logging commands to stdout

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Thu Nov 21 06:26:41 UTC 2019


laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16138 )

Change subject: logging/vty: do not print deprecated logging commands to stdout
......................................................................

logging/vty: do not print deprecated logging commands to stdout

Yes, we don't really need to poison stdout, as some osmo-* binaries
(like osmo-gapk) may want to use it for non-logging purposes.
This printf() call looks like a debugging leftover.

Change-Id: Ida35865b1c0bb3d3567918f8e89c6551c6b34103
---
M src/vty/logging_vty.c
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/vty/logging_vty.c b/src/vty/logging_vty.c
index 88ee330..9615943 100644
--- a/src/vty/logging_vty.c
+++ b/src/vty/logging_vty.c
@@ -1007,7 +1007,6 @@
 	OSMO_ASSERT(cmd);
 	cmd->string = talloc_asprintf(cmd, "logging level %s (debug|info|notice|error|fatal)",
 				    name);
-	printf("%s\n", cmd->string);
 	cmd->func = log_deprecated_func;
 	cmd->doc = LEVEL_STR
 		   "Deprecated Category\n";

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/16138
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ida35865b1c0bb3d3567918f8e89c6551c6b34103
Gerrit-Change-Number: 16138
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191121/13d73fa3/attachment.htm>


More information about the gerrit-log mailing list