This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/16054 ) Change subject: bsc: Send MS Power Control msg upon max MS power change ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/16054/2/src/osmo-bsc/gsm_data.c File src/osmo-bsc/gsm_data.c: https://gerrit.osmocom.org/c/osmo-bsc/+/16054/2/src/osmo-bsc/gsm_data.c@1754 PS2, Line 1754: rsl_chan_ms_power_ctrl(lchan); > Can we just combine this line with the 'if' statement above, so you would not need that bool? No because that function uses lchan->ms_power, so it must be set to the new value beforehand. And if I moved that into the first if condition then I'd still to set it outside it, so I think it's clearer only setting it in one place and using this bool value here. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/16054 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3d6b75578e5cb9b2ad474a0ad01362d846ebe135 Gerrit-Change-Number: 16054 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Wed, 20 Nov 2019 14:33:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <axilirator at gmail.com> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191120/c367f654/attachment.htm>