Change in osmo-bts[master]: pcuif_proto.h: extend RACH.ind with TRX and timeslot number fields

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Mon Nov 18 19:12:36 UTC 2019


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/16080 )

Change subject: pcuif_proto.h: extend RACH.ind with TRX and timeslot number fields
......................................................................


Patch Set 1:

> don't we need to increment the PCUIF VERSION in order to introduce this change?
> OR, to be forward/backward capable, have size checks on the other side?

Fortunately no. Please see last two paragraphs of the commit message.

This change basically makes use of padding bytes, since sizeof(RACH.ind) < sizeof(INFO.ind), so we're not breaking anything. Unfortunately, we cannot do the same trick with INFO.ind, because it is the largest message, and hence defines PDU length for all other messages (because we use a 'union').


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/16080
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Iff38934a108b6b1cd298669834263a7d5296c3f6
Gerrit-Change-Number: 16080
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Mon, 18 Nov 2019 19:12:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191118/de95f552/attachment.htm>


More information about the gerrit-log mailing list